MantisBT - MPfm
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000069MPfmUI | Windows | Update Librarypublic2011-04-24 11:052011-04-25 04:46
Reporterycastonguay 
Assigned Toycastonguay 
PriorityhighSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version0.4.3.8Fixed in Version0.4.3.8 
Summary0000069: Passing images in the UpdateLibraryProgress process takes a long time
DescriptionWhen the image resolution is pretty high, this slows down considerably adding files to the library.

First, the image shouldn't be passed for every song of an album of the album cover is the same. If an album has 15 songs, this means 14 less calls to ID3 tags.

Maybe the image should be fetched using a background worker in the Update Library window instead of in the Library class. But that would mean that the image would appear later than the file names.

Anyway, this needs to be optimized.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-04-24 11:05ycastonguayNew Issue
2011-04-24 11:05ycastonguayStatusnew => assigned
2011-04-24 11:05ycastonguayAssigned To => ycastonguay
2011-04-24 16:37ycastonguayTarget Version0.4.3.9 => 0.4.3.8
2011-04-25 04:46ycastonguayNote Added: 0000008
2011-04-25 04:46ycastonguayStatusassigned => resolved
2011-04-25 04:46ycastonguayFixed in Version => 0.4.3.8
2011-04-25 04:46ycastonguayResolutionopen => fixed
2012-04-17 19:12ycastonguayCategoryUpdate Library => Window - Update Library
2012-04-21 09:58ycastonguayCategoryWindow - Update Library => UI - Windows - Update Library
2012-04-22 10:10ycastonguayCategoryUI - Windows - Update Library => UI | Windows | Update Library

Notes
(0000008)
ycastonguay   
2011-04-25 04:46   
I moved the album art fetching to the Update Library window instead of Library class.

The album art is fetched only once per album. This means the individual album art for files won't be shown, but that's really rare (only Nine Inch Nails - The Slip comes to mind).