MantisBT - MPfm
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000287MPfm[All Projects] Globalpublic2012-02-13 11:442012-02-15 19:39
Reporterycastonguay 
Assigned Toycastonguay 
PriorityhighSeveritytweakReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version0.5.2.1Fixed in Version0.5.2.1 
Summary0000287: Activate Visual Studio Code Analysis with Microsoft Minimum Recommended Rules
DescriptionFix as many warnings as possible (including other warnings related to XML comments and other misc stuff).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-13 11:44ycastonguayNew Issue
2012-02-13 11:44ycastonguayStatusnew => assigned
2012-02-13 11:44ycastonguayAssigned To => ycastonguay
2012-02-13 12:07svnCheckin
2012-02-13 12:07svnNote Added: 0000407
2012-02-13 13:41svnCheckin
2012-02-13 13:41svnNote Added: 0000408
2012-02-13 13:50svnCheckin
2012-02-13 13:50svnNote Added: 0000409
2012-02-13 20:20svnCheckin
2012-02-13 20:20svnNote Added: 0000410
2012-02-13 23:26svnCheckin
2012-02-13 23:26svnNote Added: 0000411
2012-02-15 19:39ycastonguayStatusassigned => resolved
2012-02-15 19:39ycastonguayFixed in Version => 0.5.2.1
2012-02-15 19:39ycastonguayResolutionopen => fixed

Notes
(0000407)
svn   
2012-02-13 12:07   
The user admin has checked in files related to this issue (revision 299).

Comment:
MPfm 0.5.2.1
- Fixing generic warnings:
  Added a bit of XML comments, removed never used variables, removed never used exceptions in try/catch blocks, and more.

Related to issue 0000287.

Files modified:
U MPfm/branches/current/MPfm/Classes/SongQuery.cs
U MPfm/branches/current/MPfm/Configuration/MPfmConfiguration.cs
U MPfm/branches/current/MPfm/Other Screens/frmAddEditMarker.cs
U MPfm/branches/current/MPfm/Other Screens/frmEditSongMetadata.cs
U MPfm/branches/current/MPfm/frmMain.cs
U MPfm/branches/current/MPfm/frmUpdateLibraryStatus.cs
U MPfm/branches/current/MPfm.Core/Conversion.cs
U MPfm/branches/current/MPfm.Library/ConvertLibrary.cs
U MPfm/branches/current/MPfm.Library/Library.cs
U MPfm/branches/current/MPfm.Library/MPfmGateway.cs
U MPfm/branches/current/MPfm.Sound/AudioFiles/AudioFile.cs
U MPfm/branches/current/MPfm.Sound/AudioFiles/AudioTools.cs
U MPfm/branches/current/MPfm.Sound/Bass.Net/Base.cs
U MPfm/branches/current/MPfm.Sound/Bass.Net/Channel.cs
U MPfm/branches/current/MPfm.Sound/PeakFile.cs
U MPfm/branches/current/MPfm.Sound/Playlists/Playlist.cs
U MPfm/branches/current/MPfm.Sound/Playlists/PlaylistTools.cs
U MPfm/branches/current/MPfm.Sound/Tags/APEMetadata.cs
U MPfm/branches/current/MPfm.Sound/Tags/ID3v2Metadata.cs
U MPfm/branches/current/MPfm.Sound/Tags/SV7Metadata.cs
U MPfm/branches/current/MPfm.Sound/Tags/SV8Metadata.cs
U MPfm/branches/current/MPfm.WindowsControls/Audio/OutputMeter.cs
U MPfm/branches/current/MPfm.WindowsControls/Audio/VolumeFader.cs
U MPfm/branches/current/MPfm.WindowsControls/Audio/WaveFormDisplay.cs
U MPfm/branches/current/MPfm.WindowsControls/Buttons-Toolbars/Button.cs
U MPfm/branches/current/MPfm.WindowsControls/Buttons-Toolbars/TrackBar.cs
U MPfm/branches/current/MPfm.WindowsControls/Fonts/EmbeddedFontCollection.cs
U MPfm/branches/current/MPfm.WindowsControls/Labels/Label.cs
U MPfm/branches/current/MPfm.WindowsControls/Labels/LinkLabel.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/AlbumView.Designer.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/AlbumView.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/AlbumViewCache.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/SongGridView.cs
U MPfm/branches/current/MPfm.WindowsControls/Lists/ListBox.cs
U MPfm/branches/current/MPfm.WindowsControls/Misc/HScrollBar.cs
U MPfm/branches/current/MPfm.WindowsControls/Misc/Tools.cs
U MPfm/branches/current/MPfm.WindowsControls/Panel-Forms/Panel.cs
(0000408)
svn   
2012-02-13 13:41   
The user admin has checked in files related to this issue (revision 300).

Comment:
MPfm 0.5.2.1
- Finished adding and correcting all XML comments on all projects.

Related to issue 0000287.

Files modified:
U MPfm/branches/current/MPfm/Classes/DriverComboBoxItem.cs
U MPfm/branches/current/MPfm/Classes/SongQuery.cs
U MPfm/branches/current/MPfm/Other Screens/frmAddEditLoop.cs
U MPfm/branches/current/MPfm/Other Screens/frmAddEditMarker.cs
U MPfm/branches/current/MPfm/Other Screens/frmEffects.cs
U MPfm/branches/current/MPfm/Other Screens/frmPlaylist.cs
U MPfm/branches/current/MPfm/Other Screens/frmRenameSavePlaylist.cs
U MPfm/branches/current/MPfm/frmMain.cs
U MPfm/branches/current/MPfm/frmUpdateLibraryStatus.cs
U MPfm/branches/current/MPfm.Core/Conversion.cs
U MPfm/branches/current/MPfm.Library/Library.cs
U MPfm/branches/current/MPfm.Library/MPfmGateway.cs
U MPfm/branches/current/MPfm.Library/UpdateLibrary/UpdateLibrary.cs
U MPfm/branches/current/MPfm.Library/UpdateLibrary/UpdateLibraryStep.cs
U MPfm/branches/current/MPfm.Player/Events/PlayerStreamCallbackData.cs
U MPfm/branches/current/MPfm.Player/Objects/RepeatType.cs
U MPfm/branches/current/MPfm.Player/Player.cs
U MPfm/branches/current/MPfm.Sound/AudioFiles/AudioFile.cs
U MPfm/branches/current/MPfm.Sound/AudioFiles/AudioTools.cs
U MPfm/branches/current/MPfm.Sound/Bass.Net/ChannelType.cs
U MPfm/branches/current/MPfm.Sound/Bass.Net/DriverType.cs
U MPfm/branches/current/MPfm.Sound/Playlists/PlaylistItem.cs
U MPfm/branches/current/MPfm.Sound/Tags/SV8Metadata.cs
U MPfm/branches/current/MPfm.Sound/XingInfoHeaderReader.cs
U MPfm/branches/current/MPfm.WindowsControls/Audio/OutputMeter.cs
U MPfm/branches/current/MPfm.WindowsControls/Audio/WaveForm.cs
U MPfm/branches/current/MPfm.WindowsControls/Audio/WaveFormDisplay.cs
U MPfm/branches/current/MPfm.WindowsControls/Buttons-Toolbars/TrackBar.cs
U MPfm/branches/current/MPfm.WindowsControls/Fonts/EmbeddedFontCollection.cs
U MPfm/branches/current/MPfm.WindowsControls/Labels/Label.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/AlbumViewCache.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/AlbumViewItem.cs
U MPfm/branches/current/MPfm.WindowsControls/Library/SongGridView.cs
U MPfm/branches/current/MPfm.WindowsControls/Lists/ReorderListView.cs
U MPfm/branches/current/MPfm.WindowsControls/Misc/HScrollBar.cs
(0000409)
svn   
2012-02-13 13:50   
The user admin has checked in files related to this issue (revision 301).

Comment:
MPfm 0.5.2.1
- Fixed code analysis warnings for MPfm.Core.

Related to issue 0000287.

Files modified:
U MPfm/branches/current/MPfm.Core/Conversion.cs
U MPfm/branches/current/MPfm.Core/ImageManipulation.cs
(0000410)
svn   
2012-02-13 20:20   
The user admin has checked in files related to this issue (revision 302).

Comment:
MPfm 0.5.2.1
- Fixed most Code Analysis warnings for MPfm.Sound.
  (Added Serializable to exceptions, fixed and changed most try/catch blocks dealing with IDisposable objects)

Related to issue 0000287.

Files modified:
U MPfm/branches/current/MPfm.Sound/AudioFiles/AudioFile.cs
U MPfm/branches/current/MPfm.Sound/Bass.Net/Exception.cs
U MPfm/branches/current/MPfm.Sound/PeakFile.cs
U MPfm/branches/current/MPfm.Sound/Playlists/PlaylistTools.cs
U MPfm/branches/current/MPfm.Sound/Tags/APEMetadata.cs
U MPfm/branches/current/MPfm.Sound/Tags/ID3v2Metadata.cs
U MPfm/branches/current/MPfm.Sound/Tags/SV7Metadata.cs
U MPfm/branches/current/MPfm.Sound/Tags/SV8Metadata.cs
U MPfm/branches/current/MPfm.Sound/XingInfoHeaderReader.cs
U MPfm/branches/current/MPfm.WindowsControls/MPfm.WindowsControls.csproj
(0000411)
svn   
2012-02-13 23:26   
The user admin has checked in files related to this issue (revision 303).

Comment:
MPfm 0.5.2.1
- Fixed most Code Analysis warnings for MPfm, MPfm.Library and MPfm.Player.

Related to issue 0000287.

Files modified:
U MPfm/branches/current/MPfm/Other Screens/frmEffects.cs
U MPfm/branches/current/MPfm/Other Screens/frmPlaylist.cs
U MPfm/branches/current/MPfm/Program.cs
U MPfm/branches/current/MPfm/frmFirstRun.cs
U MPfm/branches/current/MPfm/frmMain.cs
U MPfm/branches/current/MPfm/frmSplash.cs
U MPfm/branches/current/MPfm/frmUpdateLibraryStatus.cs
U MPfm/branches/current/MPfm.Library/Library.cs
U MPfm/branches/current/MPfm.Library/SQLiteGateway.cs
U MPfm/branches/current/MPfm.Library/UpdateLibrary/UpdateLibraryException.cs
U MPfm/branches/current/MPfm.Player/Exceptions/PlayerCreateStreamException.cs
U MPfm/branches/current/MPfm.Player/Player.cs